ci: narrow macOS test scope to datafusion-ffi, run benchmarks on amd64#22048
Merged
ci: narrow macOS test scope to datafusion-ffi, run benchmarks on amd64#22048
Conversation
The macos-aarch64 job took ~22 min — 68% compile, 25% test. An audit of
macos-only PR failures over Mar–May 2026 (1000 failed PR runs, 30 with
macOS as the sole signal) found that nearly all the unique signal was
either:
- flaky sqllogictest metrics (~67%, e.g. push_down_filter / explain_analyze
.slt files with platform-dependent scan_efficiency_ratio numbers),
- real bugs in datafusion-benchmarks (which amd64 was excluding), or
- one genuinely macOS-specific FFI cdylib loading bug
(datafusion/ffi/src/tests/utils.rs path resolution).
So the only thing macOS uniquely catches is FFI dylib loading. Scope the
macOS job down to `cargo test -p datafusion-ffi --features integration-tests`
and let amd64 pick up the datafusion-benchmarks coverage that was being
dropped by the linux-test --exclude list.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
development-process
Contributor
|
I think we should try this to save some carbon and if it has issues we can add it back |
alamb
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #21941
The macos-aarch64 job took ~22 min - 68% compile, 25% test. An audit of macos-only PR failures over Mar-May 2026 (1000 failed PR runs, 30 with macOS as the sole signal) found that nearly all the unique signal was either:
So the only thing macOS uniquely catches is FFI dylib loading. Scope the macOS job down to
cargo test -p datafusion-ffi --features integration-testsand let amd64 pick up the datafusion-benchmarks coverage that was being dropped by the linux-test --exclude list.