fix: Incorrect behavior for FILTER on NULLs#22068
Open
neilconway wants to merge 2 commits intoapache:mainfrom
Open
fix: Incorrect behavior for FILTER on NULLs#22068neilconway wants to merge 2 commits intoapache:mainfrom
FILTER on NULLs#22068neilconway wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
If we want to backport this, let me know -- I can send a separate PR that is more minimal and doesn't use |
kosiew
approved these changes
May 8, 2026
Contributor
kosiew
left a comment
There was a problem hiding this comment.
@neilconway
Thanks for the fix.
Looks 👍 to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FILTERdoes not handle NULLs correctly #22067.Rationale for this change
In the grouping code,
accumulate_multipleandaccumulate_indicestake aBooleanArrayparameter, which has the result of the aggregate'sFILTERclause (if any). Both functions only consider the value bits of the array, not the NULL bitmap, which means they considerNULLfilter results to be effectively true, not false.What changes are included in this PR?
accumulate_multipleandaccumulate_indicesaccumulate_multipleto be more readable and make use ofNullBuffer::union_manyfilter_to_validityfilter_to_nullsto usefilter_to_validityand avoid constructing an unnecessary intermediateNullBufferaccumulate_multipleandaccumulate_indicesAre these changes tested?
Yes, with new tests added.
Are there any user-facing changes?
This changes query behavior for the affected (buggy) queries.
This PR also changes the signature of
filter_to_nulls, which is technically a public API.