Propagate field metadata through NTH_VALUE, FIRST_VALUE, and LAST_VALUE window functions#22112
Open
paleolimbot wants to merge 2 commits into
Open
Propagate field metadata through NTH_VALUE, FIRST_VALUE, and LAST_VALUE window functions#22112paleolimbot wants to merge 2 commits into
paleolimbot wants to merge 2 commits into
Conversation
github-actions
Bot
added
sqllogictest
paleolimbot
changed the title
adriangb
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
lead and lag both preserve metadata from the input field but nth_value, first_value, and last_value do not.
What changes are included in this PR?
The mechanism to calcluate the return field for nth_value was changed to match lead/lag (which had already been fixed).
Are these changes tested?
Yes, I added tests to metadata.slt
Are there any user-facing changes?
No