docs: updating arrays_zip output field naming#22133
Open
timsaucer wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
the
documentation
Member
Author
|
FYI @hsiang-c as the author of the upstream PR this caused a unit test regression in datafusion-python so I think we should have this note in the upgrade guide. |
timsaucer
added a commit
to timsaucer/datafusion-python
that referenced
this pull request
May 12, 2026
hsiang-c
reviewed
May 12, 2026
hsiang-c
approved these changes
May 12, 2026
Contributor
hsiang-c
left a comment
hsiang-c
left a comment
There was a problem hiding this comment.
Thanks for catching it @timsaucer
Left one comment on the reference.
Co-authored-by: hsiang-c <137842490+hsiang-c@users.noreply.github.com>
Member
Author
Excellent. Thank you for the correction! |
Contributor
|
(nit) An update to the PR description if possible, not a must. |
comphead
reviewed
May 12, 2026
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Let me check this real quick
comphead
reviewed
May 12, 2026
comphead
reviewed
May 12, 2026
|
|
||
| - Queries or downstream code that references the output struct fields by name | ||
| (e.g. `arrays_zip(a, b)['c0']`). Update field accessors to `'1'`, `'2'`, | ||
| etc. |
Contributor
There was a problem hiding this comment.
Suggested change
| etc. | |
| etc. Example `arrays_zip(a, b)[0]` |
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
comphead
approved these changes
May 12, 2026
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
Thanks @timsaucer and @hsiang-c for catching this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue opened, but discovered regression in unit tests in datafusion-python during upgrading to
mainRationale for this change
Documentation only to let users know that they will need to update their field naming expectations. The change happened in #20886
What changes are included in this PR?
Upgrade guide document.
Are these changes tested?
N/A