chore: enable unreachable_pub lint at workspace level#22153
Closed
rluvaton wants to merge 1 commit into
Closed
Conversation
Sets `unreachable_pub = "deny"` under `[workspace.lints.rust]` so the compiler flags items marked `pub` whose effective visibility is narrower than `pub` because of an enclosing `pub(crate)` or private module. This catches cases where `pub` reads as public API but the item is actually only reachable inside the crate, which is misleading when auditing the public surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Why looking at the code I thought I could use
InProgressSpillFilesince it marked as pub, or the functioncreate_in_progress_filethat is alsopub, butInProgressSpillFilemod is behindpub(crate)so to avoid confusion when reading the source code I'm enabling this lintWhat changes are included in this PR?
unreachable_pub = "deny"under[workspace.lints.rust]in the rootCargo.toml.Are these changes tested?
CI
Are there any user-facing changes?
No.