perf: Elimiate SortExec on generate_series()#22238
Open
2010YOUY01 wants to merge 3 commits into
Open
Conversation
2010YOUY01
commented
May 16, 2026
| /// Now only `Int64` argument type is supported | ||
| fn output_ordering(&self, schema: &Schema) -> Option<PhysicalSortExpr> { | ||
| let step = match &self.args { | ||
| GenSeriesArgs::Int64Args { step, .. } => *step, |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if time type allows step like 1 year -13 month, so I've kept them outside the scope of this PR for simplicity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Eliminates
SortExecongenerate_series()by exposing the existing sort order property in the data sourceExecutionPlan, the existing optimizer heuristics will remove it automatically.Demo in
datafusion-cli:main
PR
Are these changes tested?
slt
Are there any user-facing changes?