fix negative array subscripts should not index from the end#22302
Open
xiedeyantu wants to merge 1 commit into
Open
fix negative array subscripts should not index from the end#22302xiedeyantu wants to merge 1 commit into
xiedeyantu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
PostgreSQL treats negative array subscripts as out of bounds and returns
NULL. DataFusion was incorrectly interpreting negative subscripts as indexing from the end of the array, which caused behavioral mismatch.What changes are included in this PR?
array_element/ array subscript evaluation to treat non-positive indexes as out of bounds and returnNULL.array_elementbehavior, including the[-1]case.Are these changes tested?
Yes.
Validated with:
cargo test -p datafusion-functions-nested test_array_element_non_positive_indexes_return_nullcargo test -p datafusion-sqllogictest --test sqllogictests array_indexcargo test -p datafusion-sqllogictest --test sqllogictests exprAre there any user-facing changes?
Yes. Array subscripts with negative indexes now return
NULLinstead of indexing from the end, aligning DataFusion behavior with PostgreSQL.