Skip to content

perf: combine_hashes for byte-view multi-column rehash #22352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dandandan wants to merge 1 commit into from
+3 −9
Closed

perf: combine_hashes for byte-view multi-column rehash #22352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions datafusion/common/src/hash_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,9 +345,7 @@ fn hash_string_view_array_inner<
// all views are inlined, no need to access external buffers
if !HAS_BUFFERS || view_len <= 12 {
if REHASH {
let mut hasher = seeded_state(*hash).build_hasher();
v.hash_write(&mut hasher);
*hash = hasher.finish();
*hash = combine_hashes(v.hash_one(random_state), *hash);
} else {
*hash = v.hash_one(random_state);
}
Expand All @@ -356,9 +354,7 @@ fn hash_string_view_array_inner<
// view is not inlined, so we need to hash the bytes as well
let value = view_bytes(view_len, v);
if REHASH {
let mut hasher = seeded_state(*hash).build_hasher();
value.hash_write(&mut hasher);
*hash = hasher.finish();
*hash = combine_hashes(value.hash_one(random_state), *hash);
} else {
*hash = value.hash_one(random_state);
}
Expand Down Expand Up @@ -390,9 +386,7 @@ fn hash_generic_byte_view_array<T: ByteViewType>(
}
(false, false, true) => {
for (hash, &view) in hashes_buffer.iter_mut().zip(array.views().iter()) {
let mut hasher = seeded_state(*hash).build_hasher();
view.hash_write(&mut hasher);
*hash = hasher.finish();
*hash = combine_hashes(view.hash_one(random_state), *hash);
}
}
(false, true, false) => hash_string_view_array_inner::<T, false, true, false>(
Expand Down
Loading