Revert "Add ExecutionPlan::apply_expressions() (#20337)"#22437
Open
alamb wants to merge 3 commits into
Open
Conversation
This reverts commit a5f490e. # Conflicts: # datafusion/core/tests/physical_optimizer/filter_pushdown.rs # datafusion/datasource-json/src/source.rs # datafusion/datasource/src/file_scan_config/mod.rs # datafusion/datasource/src/source.rs # datafusion/ffi/src/execution_plan.rs # datafusion/physical-optimizer/src/ensure_coop.rs # datafusion/physical-plan/src/execution_plan.rs # datafusion/physical-plan/src/union.rs # docs/source/library-user-guide/custom-table-providers.md # docs/source/library-user-guide/upgrading/54.0.0.md
github-actions
Bot
added
documentation
adriangb
approved these changes
May 21, 2026
Contributor
Author
|
Once we merge this I will backport it to branch-54 as well |
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ExecutionPlan::apply_expressions()#20337Rationale for this change
ExecutionPlan::apply_expressions()was added in #20337 with no default implementation, forcing every customExecutionPlan,FileSource, andDataSourceimplementor to add the method as part of upgrading to DataFusion 54.As discussed on #22415, per @LiaCastaneda and @adriangb the method is not yet called from anywhere in DataFusion and the originally intended use (dynamic-filter discovery/serialization for distributed scenarios) is blocked on other in-progress work (#20009, #21350).
The combined effect on downstream users is a required code change with no immediate benefit, and ambiguity about what a "correct" implementation even means today (e.g. is returning
Ok(TreeNodeRecursion::Continue)is safe right now but becomes incorrect as soon as the method starts being used by an optimizer pass?.The plan agreed in the discussion is to remove the API from the 54.0 release and re-add it together with the concrete consumer that needs it. cc @adriangb @LiaCastaneda @milenkovicm.
What changes are included in this PR?
git revert -m 1of the merge commit, with the following manual conflict resolutions and follow-ups:Are these changes tested?
By CI
Are there any user-facing changes?
Yes -- this removes the new public API:
ExecutionPlan::apply_expressionsFileSource::apply_expressionsDataSource::apply_expressionsThese were only added in 54 and are not yet released. Custom implementors no longer need to implement these methods.