port NegativeExpr to use the try_to_proto / try_from_proto hooks#22483
Open
kevinhongzl wants to merge 2 commits into
Open
port NegativeExpr to use the try_to_proto / try_from_proto hooks#22483kevinhongzl wants to merge 2 commits into
NegativeExpr to use the try_to_proto / try_from_proto hooks#22483kevinhongzl wants to merge 2 commits into
Conversation
github-actions
Bot
added
physical-expr
Contributor
|
@kevinhongzl could you rebase and resolve conflicts please? |
Author
|
@adriangb I've fixed the merge conflicts, and it's now ready to be merged. |
Contributor
|
Could you add some tests please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NegativeExprto usetry_to_proto/try_from_proto#22426Rationale for this change
This change is part of the per-expression proto hooks migration #22418. I moved the serialization and deserialization of
NegativeExprinto its proto hooks, keeping it aligned with the new pattern used by migrated physical expressions and reducing special-case branching in the shared conversion code.What changes are included in this PR?
try_to_protoandtry_from_prototoNegativeExprNegativeExprserialization branchphysical_plan/from_proto.rsto route physical proto decode throughtry_from_protoAre these changes tested?
Yes. This PR is verified by running
cargo fmt --all -- --checkcargo check -p datafusion-physical-expr --features protocargo check -p datafusion-protocargo test -p datafusion-proto --test proto_integration roundtrip_physical_plancargo test -p datafusion-proto --test proto_integration roundtrip_physical_exprgit diff --checkAre there any user-facing changes?
No user-facing changes are intended.