refactor: port Literal physical expr proto hooks#22492
Open
officialasishkumar wants to merge 1 commit into
Open
refactor: port Literal physical expr proto hooks#22492officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
github-actions
Bot
added
physical-expr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Literalto usetry_to_proto/try_from_proto#22427.Rationale for this change
DataFusion is migrating built-in physical expressions to own their protobuf serialization and deserialization through the
try_to_proto/try_from_protohooks added in #21929.Literalstill used the central physical expression proto match.What changes are included in this PR?
This ports
Literalto the per-expression proto hook pattern and updates physical expression decoding to delegate literal reconstruction toLiteral::try_from_proto. The protobuf wire format is unchanged.Are these changes tested?
Yes.
cargo fmt --all -- --checkcargo test -p datafusion-proto --test proto_integration cases::roundtrip_physical_plan::roundtrip_filter_with_not_and_in_listcargo test -p datafusion-proto --test proto_integration cases::roundtrip_physical_plan::roundtrip_hash_table_lookup_expr_to_litcargo test -p datafusion-proto --test proto_integration cases::roundtrip_physical_plan::roundtrip_call_null_scalar_struct_dictcargo test -p datafusion-proto --test proto_integration cases::roundtrip_physical_plan::test_round_trip_human_displaygit diff --checkAre there any user-facing changes?
No. This is an internal serialization refactor with the same serialized representation.