Fix Filter / where clause without column names is removed in optimization pass #225
+44
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #220
Rationale for this change
DataFusion gives wrong results for filters that don't reference any column
What changes are included in this PR?
Workarounds the issue by not pushing down predicates that do not reference any column (1=2, FALSE, TRUE).
As we should be able to remove these anyway with constant folding and removing/replacing
WHERE FALSE/WHERE TRUE, I think this is a good option.Are there any user-facing changes?
No, results should be correct now.