feat(substrait): generate Substrait function YAML#22572
Open
notfilippo wants to merge 2 commits into
Open
Conversation
notfilippo
force-pushed
the
filippo.rossi/feat-substrait-generate-substrait-function-yaml-nqvwpkqxzoqw
branch
from
ab552df to
60c751f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #22563.
Rationale for this change
See linked issue.
What changes are included in this PR?
Adds
datafusion_substrait::function_yaml, a configurable API for generating Substrait function YAML from a DataFusion function inventory.Adds the
print_substrait_function_yamlbinary with stdout,--check, and--writemodes.Commits the generated DataFusion function YAML file under
datafusion/substrait/extensions/, which is the bulk of the diff.Are these changes tested?
Yes.
Are there any user-facing changes?
No breaking changes. This adds a new Substrait YAML generation API, binary, and generated extension artifact.