fix: Avoid incorrectly rounding large integers in nanvl#22575
Open
neilconway wants to merge 2 commits into
Open
fix: Avoid incorrectly rounding large integers in nanvl#22575neilconway wants to merge 2 commits into
nanvl#22575neilconway wants to merge 2 commits into
Conversation
github-actions
Bot
added
sqllogictest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
nanvlincorrectly rounds on integer input #22567Rationale for this change
nanvl's function signature listedFloat16first, which meant that data types not natively supported by the function (e.g., integers) would be converted toFloat16. This resulted in unnecessary and incorrect rounding for large integer inputs (e.g.,nanvl(16777217, 1)returned incorrect results).Instead, we now convert non-floating point inputs to
Float64. This might still round for inputs larger than 2^53, but it's the best we can do without more fundamental changes. Floating point inputs are coerced to the widest float type they have in common -- e.g., (Float16,Float32) ->Float32.What changes are included in this PR?
Are these changes tested?
Yes; new tests added.
Are there any user-facing changes?
Yes;
nanvlnow avoids rounding in more cases.