chore: update Rust toolchain to 1.96.0#22611
Open
Dandandan wants to merge 2 commits into
Open
Conversation
Bump the pinned Rust toolchain from 1.95.0 to 1.96.0 in rust-toolchain.toml and update the matching rust-analyzer component example in the development environment docs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rust 1.96's clippy adds the `unnecessary_result_map_or_else` lint, which fires on the `PG_URI` env lookup in the postgres sqllogictest engine. Replace `map_or_else(.., identity)` with `unwrap_or_else`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Keeps the pinned Rust toolchain current. This bumps the toolchain used to
compile the workspace and run CI jobs from
1.95.0to1.96.0.What changes are included in this PR?
rust-toolchain.toml: bumpchannelfrom1.95.0to1.96.0.docs/source/contributor-guide/development_environment.md: update therustup component add --toolchain 1.96.0 rust-analyzerexample to match.The MSRV (
rust-version = "1.88.0"in the workspaceCargo.toml) isunchanged.
Are these changes tested?
Covered by existing CI, which compiles and lints the workspace with the
pinned toolchain.
cargo clippy --all-targets --all-features -- -D warningswas run locally against 1.96.0.
Are there any user-facing changes?
No. This only affects the toolchain used by contributors and CI.