[branch-54] chore: Cleanup and refactor build_join in ScalarSubqueryToJoin (#…#22693
Merged
Merged
Conversation
…pache#22316) ## Which issue does this PR close? - N/A ## Rationale for this change This PR cleans up and refactors `build_join`, which is used as part of rewriting correlated subqueries. ## What changes are included in this PR? * This routine only needs to handle correlated subqueries now, so simplify the code and add an assert to that effect * Clarify variable names * Improve comments * Hoist a few variables outside of loops, when possible * Use `when`, `lit` and `not` helpers to build the `CASE` expression ## Are these changes tested? Yes, covered by existing tests. ## Are there any user-facing changes? No, no functional changes at all.
gabotechs
approved these changes
Jun 1, 2026
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR packports #22316 from @neilconway to branch-54