fix: Correct output-count stats for partitioned partial aggs#22780
Open
neilconway wants to merge 1 commit into
Open
fix: Correct output-count stats for partitioned partial aggs#22780neilconway wants to merge 1 commit into
neilconway wants to merge 1 commit into
Conversation
Contributor
Author
|
cc @asolimando |
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Contributor
Author
|
(This is a pretty marginal corner-case that I ran across while chasing other stuff, but still seems worth fixing.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
A partial aggregate with no group by expression emits one row per output partition, even for input partitions that did not receive any rows. The stats code gets this incorrect, and claims that the partial agg outputs
Exact(0)rows in this scenario. This is off by a factor ofpartition_count, which can lead to suboptimal planning decisions downstream.What changes are included in this PR?
statistics_innerand adjuststatistics_inneras described aboveAre these changes tested?
Yes; new tests added.
Are there any user-facing changes?
No.