-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Count distinct boolean #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pjmore looks good! Maybe you could also add a test for it? |
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 76.46% 76.50% +0.04%
==========================================
Files 135 135
Lines 23250 23287 +37
==========================================
+ Hits 17777 17815 +38
+ Misses 5473 5472 -1
Continue to review full report at Codecov.
|
|
@Dandandan I've added a test. |
Dandandan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@pjmore thanks! Could you fix the clippy error? |
|
This is great @pjmore -- thank you -- I also tested locally and it works as advertised. 👍 👍 |
Which issue does this PR close?
Closes #202 .
What changes are included in this PR?
Modified the method to_array_of_size from ScalarValue to add support for boolean lists.
Are there any user-facing changes?
I don't believe so, I couldn't find any relevant documentation about supported datatypes for COUNT DISTINCT but I'm not sure.