[draft] Rename Distribution::HashPartitioned to Distribution::KeyPartitioned#23241
Closed
gabotechs wants to merge 1 commit into
Closed
[draft] Rename Distribution::HashPartitioned to Distribution::KeyPartitioned#23241gabotechs wants to merge 1 commit into
gabotechs wants to merge 1 commit into
Conversation
cc6c2f5 to
c2ab673
Compare
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Contributor
Author
|
Closing in favor of #23259 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Just trying out what would be the actual impact of the rename, not meant to be merged
Which issue does this PR close?
Rationale for this change
Distribution::HashPartitionedis an unfortunate naming that does not really reflect the real distribution requirement: inputs do not need to be partitioned by a hashing algorithm, they can be partitioned however as long as the same key always falls in the same partition.What changes are included in this PR?
Just a plain rename Distribution::HashPartitioned -> Distribution::KeyPartitioned
Are these changes tested?
By the compiler mainly, as this is just a rename.
Are there any user-facing changes?
Yes, people consuming
Distribution::HashPartitionedneed to rename their code toDistribution::KeyPartitionedBlast radius of the public API change
Findings from GitHub code search: this rename does affect real downstream consumers that construct or pattern-match
Distribution::HashPartitioned. Notable examples:GapFillExec::required_input_distributionandSeriesLimitExec::required_input_distribution.dynamic_join.rs.pass_distribution.rs,merge_scan.rs, andnormalize.rs.barrier.rsandvalidation.rs.merge_cardinality_check.rs,writer_exec.rs, anddv_writer_exec.rs.There are additional smaller downstream hits, for example Optiprism, datafusion-bio-functions, and jammi-ai.