Use local coalescers in repartition#23269
Closed
Rachelint wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
run benchmarks clickbench_partitioned |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing support-local-coalesce-in-repartition (51559c5) to 742361b (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The current producer-side repartition coalescer is shared by all input tasks for each output partition. That adds synchronization around every coalesced batch path when multiple input tasks target the same output partition.
What changes are included in this PR?
This PR replaces the shared per-output-partition coalescer with local per-producer-channel coalescers in
RepartitionExec:LimitedBatchCoalescerStreamingMergeBuilderArc<Mutex<LimitedBatchCoalescer>>and active-sender tracking are removedAre these changes tested?
Ran:
cargo fmt --allcargo check -p datafusion-physical-plancargo clippy -p datafusion-physical-plan --all-targets --all-features -- -D warningscargo clippy --all-targets --all-features -- -D warningsExisting repartition tests cover the coalescing and spilling paths.
Are there any user-facing changes?
No user-facing API changes.