Perf: Add short circuit for primitive vectorized equal_to#23343
Open
Rich-T-kid wants to merge 1 commit into
Open
Perf: Add short circuit for primitive vectorized equal_to#23343Rich-T-kid wants to merge 1 commit into
Rich-T-kid wants to merge 1 commit into
Conversation
Contributor
Author
|
This is the only trait to not follow the pattern and its needed for #23342 to work correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
other
groupColumntraits follow the pattern of short circuiting the equal_to comparison if a previousgroupColumnset that bit to zero. This is because all traits needs to assert that the value is the same for each row, otherwise its a new tuple. This avoids an un-needed (potentially expensive) comparison.What changes are included in this PR?
adds an early check to read the bit at the current index.
Are these changes tested?
yes
Are there any user-facing changes?
no