Skip to content

Conversation

@Dandandan
Copy link
Contributor

@Dandandan Dandandan commented May 2, 2021

Which issue does this PR close?

Closes #241

Rationale for this change

It would help users that use the sql syntax if we have a documented reference

What changes are included in this PR?

Initial setup for documenting the sql syntax.

Are there any user-facing changes?

No, if the book is published, this allows for more discoverability into the syntax.

Screenshot:

image

@codecov-commenter
Copy link

Codecov Report

Merging #242 (fb0178b) into master (c945b03) will not change coverage.
The diff coverage is n/a.

❗ Current head fb0178b differs from pull request most recent head ebbece5. Consider uploading reports for the commit ebbece5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   76.46%   76.46%           
=======================================
  Files         135      135           
  Lines       23250    23250           
=======================================
  Hits        17777    17777           
  Misses       5473     5473           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c945b03...ebbece5. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dandandan -- I also think we should strive to (re)use as much other standard SQL as possible (aka not aim to write a complete SQL reference book). Introductory material (such as this PR) as well as datafusion specific things make a lot of sense to me.

@alamb alamb merged commit d700cc1 into apache:master May 3, 2021
@houqp houqp added datafusion documentation Improvements or additions to documentation labels Jul 29, 2021
H0TB0X420 pushed a commit to H0TB0X420/datafusion that referenced this pull request Oct 7, 2025
…arrow Table (apache#242)

* Implement from_arrow_table(), from_pydict() & from_pylist()

* Refactor functions

* Implement from_pandas() & from_polars()

* Document new import functions

* Fix clippy errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document SQL syntax in user guide

4 participants