Fix some 404 links in the contribution guide #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
alamb
approved these changes
May 17, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I checked the links as they were rendered here: https://github.com/hi-rustin/arrow-datafusion/blob/rustin-patch-links/CONTRIBUTING.md
LGTM 👍
Thank you @hi-rustin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hi-rustin rustin.liu@gmail.com
Which issue does this PR close?
ref #2560
What changes are included in this PR?
Fix some 404 links in the
How to add a new scalar function.I also wanted to fix the link in
How to add a new aggregate function, but I couldn't figure out the current code path for it. So I didn't fix it.Are there any user-facing changes?
None