if none columns in window expr are needed, remove the window exprs #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
reviewed
May 28, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @AssHero -- can you please add a test case to this PR showing that it fixes the issue reported on #2542?
Perhaps you can add the reproducer from @mateuszkj to https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/sql/window.rs?
Contributor
Author
yes, i can add a test case. |
alamb
approved these changes
May 29, 2022
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @AssHero
Contributor
Author
My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2542
Rationale for this change
if the columns in window exprs are not referenced by operator, we can remove the window exprs.
What changes are included in this PR?
remove the window exprs in projection_push_down.rs