Skip to content

Conversation

@Ted-Jiang
Copy link
Member

@Ted-Jiang Ted-Jiang commented Jun 13, 2022

Which issue does this PR close?

it's better output which rule is running in debug log.
I got confused when debugging optimizer.
Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label Jun 13, 2022
@Ted-Jiang Ted-Jiang closed this Jun 13, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ted-Jiang

You probably know it, but you can also use EXPLAIN VERBOSE to see the output of the plans after each pass

For example:

EXPLAIN VERBOSE SELECT * from foo where x > 5

@alamb alamb merged commit a957778 into apache:master Jun 13, 2022
@waynexia
Copy link
Member

These logs are useful to me. They are exactly what I add when debugging #2712 🤣 (some panicking rules cannot benefit from EXPLAIN)

@Ted-Jiang
Copy link
Member Author

Thanks @Ted-Jiang

You probably know it, but you can also use EXPLAIN VERBOSE to see the output of the plans after each pass

For example:

EXPLAIN VERBOSE SELECT * from foo where x > 5

@alamb Thanks a lot for your kindly advice! Like @waynexia said, our team send logical plan to datafusion, it's easy to debug in this way.(Not want change our code 😂)

@alamb
Copy link
Contributor

alamb commented Jun 14, 2022

Makes sense -- I just wanted to point out the EXPLAIN VERBOSE thing too

waynexia pushed a commit to waynexia/arrow-datafusion that referenced this pull request Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants