Skip to content

Conversation

@waynexia
Copy link
Member

Signed-off-by: Ruihang Xia waynestxia@gmail.com

Which issue does this PR close?

Ref #2715

Rationale for this change

#2715 fixed that CSE intermediate projection plan may contain duplicate fields but forget to add a UT to cover it.

This UT test the behavior by trying to build intermediate projection plan twice with the same input. To simulate (sort of) the original scenario that calls optimizer twice. cc @alamb

What changes are included in this PR?

add an UT redundant_project_fields

Are there any user-facing changes?

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the optimizer Optimizer rules label Jun 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2747 (43d5fba) into master (8adc1b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2747   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files         270      270           
  Lines       47915    47926   +11     
=======================================
+ Hits        40695    40706   +11     
  Misses       7220     7220           
Impacted Files Coverage Δ
...tafusion/optimizer/src/common_subexpr_eliminate.rs 94.11% <100.00%> (+0.17%) ⬆️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/core/src/physical_plan/hash_join.rs 96.12% <0.00%> (ø)
datafusion/optimizer/src/utils.rs 34.21% <0.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8adc1b6...43d5fba. Read the comment docs.


Ok(())
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @waynexia 👍

@alamb alamb merged commit ddf96ca into apache:master Jun 18, 2022
@waynexia waynexia deleted the test-cse-project branch June 20, 2022 02:56
waynexia added a commit to waynexia/arrow-datafusion that referenced this pull request Jun 20, 2022
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants