minor: panic rather than fail silently on bad dictionary in hash join #2767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 22, 2022
|
|
||
| match values_index { | ||
| Ok(index) => (as_string_array(left_array.values()), Some(index)), | ||
| _ => (as_string_array(left_array.values()), None) |
Contributor
Author
There was a problem hiding this comment.
this ignores invalid data in DictionaryArrays (treats them as though they were NULLs) -- I think panic is better
Codecov Report
@@ Coverage Diff @@
## master #2767 +/- ##
==========================================
+ Coverage 84.93% 84.95% +0.01%
==========================================
Files 271 271
Lines 48146 48140 -6
==========================================
+ Hits 40892 40896 +4
+ Misses 7254 7244 -10
Continue to review full report at Codecov.
|
Member
|
Thank you @alamb , let's merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #2721 from @AssHero
Rationale for this change
If a
DictionaryArraycontains an index that can't be converted tousize(e.g. it is negative) it is invalid. Previously if this happened the error would be silently ignored.What changes are included in this PR?
Change the code to panic if an invalid index was provided so any such error will be clearer
Are there any user-facing changes?
no