add TimeUnit::Second as signature for ToTimestampSeconds #3004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… other units; add test cases
Which issue does this PR close?
Closes #2998
Rationale for this change
to make this works
the subquery
select to_timestamp_seconds(1) as aoutput a asTimeUnit::Second. However it's not into_timestamp_secondsits own signatures, so it's been converted to utf-81970-01-01T00:00:01as utf-8 listed in the first signature. While there's no explicit timezone, it will be deemed as local time, that will cause the secondto_timestamp_secondsproduce the timestamp with timezone offset. https://docs.rs/arrow/19.0.0/arrow/compute/kernels/cast_utils/fn.string_to_timestamp_nanos.html#timezone--offset-handlingThis pr is to add
TimeUnit::Secondas signature forToTimestampSecondsimilar as other units:
What changes are included in this PR?
add
TimeUnit::Secondas signature forToTimestampSecondadd
TimeUnit::Millisecondas signature forToTimestampMillisadd
TimeUnit::Microsecondas signature forToTimestampMicrosadd
TimeUnit::Nanosecondas signature forToTimestampAre there any user-facing changes?
No