Skip to content

to_timestamp i32 coerced to i64 #3047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 6, 2022
Merged

to_timestamp i32 coerced to i64 #3047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3e38dc8
to_timestamp i32 coerced to i64
waitingkuo Aug 5, 2022
e546eec
dummy commit to trigger action
waitingkuo Aug 5, 2022
bae8d78
dummy commit to trigger action
waitingkuo Aug 5, 2022
d5217ed
dummy commit to trigger git action
waitingkuo Aug 5, 2022
57df97f
dummy commit to trigger git action
waitingkuo Aug 5, 2022
883c85a
add more test cases
waitingkuo Aug 6, 2022
30c9993
cargo fmt
waitingkuo Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions datafusion/core/tests/sql/timestamp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1065,3 +1065,83 @@ async fn cast_to_timestamp_micros_twice() -> Result<()> {

Ok(())
}

#[tokio::test]
async fn to_timestamp_i32() -> Result<()> {
let ctx = SessionContext::new();

let sql = "select to_timestamp(cast (1 as int));";
Copy link
Contributor

@alamb alamb Aug 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add to_timestamp_seconds(..), to_timestamp_milliseconds(..) etc here?

let results = execute_to_batches(&ctx, sql).await;

let expected = vec![
"+--------------------------------------+",
"| totimestamp(CAST(Int64(1) AS Int32)) |",
"+--------------------------------------+",
"| 1970-01-01 00:00:00.000000001 |",
"+--------------------------------------+",
];

assert_batches_eq!(expected, &results);

Ok(())
}

#[tokio::test]
async fn to_timestamp_micros_i32() -> Result<()> {
let ctx = SessionContext::new();

let sql = "select to_timestamp_micros(cast (1 as int));";
let results = execute_to_batches(&ctx, sql).await;

let expected = vec![
"+--------------------------------------------+",
"| totimestampmicros(CAST(Int64(1) AS Int32)) |",
"+--------------------------------------------+",
"| 1970-01-01 00:00:00.000001 |",
"+--------------------------------------------+",
];

assert_batches_eq!(expected, &results);

Ok(())
}

#[tokio::test]
async fn to_timestamp_millis_i32() -> Result<()> {
let ctx = SessionContext::new();

let sql = "select to_timestamp_millis(cast (1 as int));";
let results = execute_to_batches(&ctx, sql).await;

let expected = vec![
"+--------------------------------------------+",
"| totimestampmillis(CAST(Int64(1) AS Int32)) |",
"+--------------------------------------------+",
"| 1970-01-01 00:00:00.001 |",
"+--------------------------------------------+",
];

assert_batches_eq!(expected, &results);

Ok(())
}

#[tokio::test]
async fn to_timestamp_seconds_i32() -> Result<()> {
let ctx = SessionContext::new();

let sql = "select to_timestamp_seconds(cast (1 as int));";
let results = execute_to_batches(&ctx, sql).await;

let expected = vec![
"+---------------------------------------------+",
"| totimestampseconds(CAST(Int64(1) AS Int32)) |",
"+---------------------------------------------+",
"| 1970-01-01 00:00:01 |",
"+---------------------------------------------+",
];

assert_batches_eq!(expected, &results);

Ok(())
}
8 changes: 4 additions & 4 deletions datafusion/expr/src/function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,48 +348,48 @@ pub fn signature(fun: &BuiltinScalarFunction) -> Signature {
BuiltinScalarFunction::ToTimestamp => Signature::uniform(
1,
vec![
DataType::Utf8,
DataType::Int64,
DataType::Timestamp(TimeUnit::Nanosecond, None),
DataType::Timestamp(TimeUnit::Microsecond, None),
DataType::Timestamp(TimeUnit::Millisecond, None),
DataType::Timestamp(TimeUnit::Second, None),
DataType::Utf8,
],
fun.volatility(),
),
BuiltinScalarFunction::ToTimestampMillis => Signature::uniform(
1,
vec![
DataType::Utf8,
DataType::Int64,
DataType::Timestamp(TimeUnit::Nanosecond, None),
DataType::Timestamp(TimeUnit::Microsecond, None),
DataType::Timestamp(TimeUnit::Millisecond, None),
DataType::Timestamp(TimeUnit::Second, None),
DataType::Utf8,
],
fun.volatility(),
),
BuiltinScalarFunction::ToTimestampMicros => Signature::uniform(
1,
vec![
DataType::Utf8,
DataType::Int64,
DataType::Timestamp(TimeUnit::Nanosecond, None),
DataType::Timestamp(TimeUnit::Microsecond, None),
DataType::Timestamp(TimeUnit::Millisecond, None),
DataType::Timestamp(TimeUnit::Second, None),
DataType::Utf8,
],
fun.volatility(),
),
BuiltinScalarFunction::ToTimestampSeconds => Signature::uniform(
1,
vec![
DataType::Utf8,
DataType::Int64,
DataType::Timestamp(TimeUnit::Nanosecond, None),
DataType::Timestamp(TimeUnit::Microsecond, None),
DataType::Timestamp(TimeUnit::Millisecond, None),
DataType::Timestamp(TimeUnit::Second, None),
DataType::Utf8,
],
fun.volatility(),
),
Expand Down