MINOR: remove out-of-date is_dictionary checks from binary_rule.rs #3552
MINOR: remove out-of-date is_dictionary checks from binary_rule.rs #3552alamb merged 1 commit intoapache:masterfrom
Conversation
…ented in arrow-rs already
| } | ||
|
|
||
| if left_type == right_type && !is_dictionary(left_type) { | ||
| if left_type == right_type { |
There was a problem hiding this comment.
this is_dictionary() call would never be true anyway due to the checks above. probably copy/paste duplication?
alamb
left a comment
There was a problem hiding this comment.
Thanks @kmitchener
cc @tustvold
I restarted the failing CI job (mac) as it seems to be unrelated to this PR and more of an infrastructure problem
|
Thanks again @kmitchener |
|
Benchmark runs are scheduled for baseline = ff718d0 and contender = cec6395. cec6395 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
These reference an old PR that was resolved in arrow-rs months ago. Tests still pass without these checks.
What changes are included in this PR?
Are there any user-facing changes?