Skip to content

MINOR: remove out-of-date is_dictionary checks from binary_rule.rs #3552

Merged
alamb merged 1 commit intoapache:masterfrom
kmitchener:remove-dictionary-specific-checks
Sep 21, 2022
Merged

MINOR: remove out-of-date is_dictionary checks from binary_rule.rs #3552
alamb merged 1 commit intoapache:masterfrom
kmitchener:remove-dictionary-specific-checks

Conversation

@kmitchener
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

These reference an old PR that was resolved in arrow-rs months ago. Tests still pass without these checks.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added the logical-expr Logical plan and expressions label Sep 20, 2022
}

if left_type == right_type && !is_dictionary(left_type) {
if left_type == right_type {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is_dictionary() call would never be true anyway due to the checks above. probably copy/paste duplication?

Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kmitchener

cc @tustvold

I restarted the failing CI job (mac) as it seems to be unrelated to this PR and more of an infrastructure problem

@alamb alamb merged commit cec6395 into apache:master Sep 21, 2022
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Sep 21, 2022

Thanks again @kmitchener

@ursabot
Copy link
Copy Markdown

ursabot commented Sep 21, 2022

Benchmark runs are scheduled for baseline = ff718d0 and contender = cec6395. cec6395 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kmitchener kmitchener deleted the remove-dictionary-specific-checks branch September 27, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logical-expr Logical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants