Simplify null division.#3625
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3625 +/- ##
==========================================
- Coverage 86.07% 85.99% -0.09%
==========================================
Files 300 300
Lines 56337 56457 +120
==========================================
+ Hits 48494 48552 +58
- Misses 7843 7905 +62
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alamb
left a comment
There was a problem hiding this comment.
Thanks @HaoYang670 -- I think the comments may be mixed up but otherwise 👍
| op: Divide, | ||
| right, | ||
| } if left == right && is_null(&left) => *left, | ||
| } if is_null(&right) => *right, |
There was a problem hiding this comment.
Isn't this checking for A / null (not null / A as the comments suggest)?
(as in I think the comments are backwards)
There was a problem hiding this comment.
Thank you for catching this, I will update.
Signed-off-by: remzi <13716567376yh@gmail.com>
|
Benchmark runs are scheduled for baseline = a1b2112 and contender = 6d2b417. 6d2b417 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
Closes #3624.
Rationale for this change
What changes are included in this PR?
Simplify
A / nullandnull / Ato null.Add tests.
Are there any user-facing changes?