Simplify multiplication by 0 and by null
#3627
Conversation
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
looks great -- thank you @HaoYang670
| | Expr::Literal(ScalarValue::UInt64(Some(0))) => true, | ||
| Expr::Literal(ScalarValue::Float32(Some(v))) if *v == 0. => true, | ||
| Expr::Literal(ScalarValue::Float64(Some(v))) if *v == 0. => true, | ||
| _ => false, |
There was a problem hiding this comment.
I wonder if we can also support ScalarValue::Decimal?
There was a problem hiding this comment.
We could create a follow-up ticket to add Decimal.
|
Filed #3643 to track adding Decimal support |
|
Benchmark runs are scheduled for baseline = d1e3bd7 and contender = 41b59cf. 41b59cf is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
Closes #3626.
Rationale for this change
Please look at the issue.
What changes are included in this PR?
Add 2 simplification rules and tests
Are there any user-facing changes?