Skip to content

Simplification Rules for Modulo Operator#3669

Merged
alamb merged 6 commits intoapache:masterfrom
askoa:simplify-modulo
Oct 3, 2022
Merged

Simplification Rules for Modulo Operator#3669
alamb merged 6 commits intoapache:masterfrom
askoa:simplify-modulo

Conversation

@askoa
Copy link
Copy Markdown
Contributor

@askoa askoa commented Sep 30, 2022

Which issue does this PR close?

Closes #3664

Are there any user-facing changes?

No

@github-actions github-actions Bot added the optimizer Optimizer rules label Sep 30, 2022
@askoa
Copy link
Copy Markdown
Contributor Author

askoa commented Sep 30, 2022

The CI failure is unrelated to this PR.

HaoYang670
HaoYang670 reviewed Oct 1, 2022
View reviewed changes
Comment thread datafusion/optimizer/src/simplify_expressions.rs Outdated
HaoYang670
HaoYang670 reviewed Oct 1, 2022
View reviewed changes
Comment thread datafusion/optimizer/src/simplify_expressions.rs Outdated
@askoa
Copy link
Copy Markdown
Contributor Author

askoa commented Oct 1, 2022

CI failure unrelated to the PR.

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Oct 2, 2022

Ticket for CI coverage failure: #3678

alamb
alamb reviewed Oct 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @askoa -- I have a suggestion about the error but otherwise 👍

Comment thread datafusion/optimizer/src/simplify_expressions.rs
@askoa askoa mentioned this pull request Oct 2, 2022
Closed
@askoa askoa marked this pull request as draft October 2, 2022 13:36
@askoa askoa marked this pull request as ready for review October 3, 2022 10:22
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Oct 3, 2022

Thanks again @askoa

@alamb alamb merged commit 1ed7a6f into apache:master Oct 3, 2022
@ursabot
Copy link
Copy Markdown

ursabot commented Oct 3, 2022

Benchmark runs are scheduled for baseline = 85c11c1 and contender = 1ed7a6f. 1ed7a6f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@askoa askoa deleted the simplify-modulo branch December 1, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

+1 more reviewer

@HaoYang670 HaoYang670 HaoYang670 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

optimizer Optimizer rules

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add simplification rules for the Modulo operator

4 participants

@askoa @alamb @ursabot @HaoYang670