Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Oct 4, 2022

Which issue does this PR close?

Closes #3704

Rationale for this change

Fixes a recent regression - see issue for details

What changes are included in this PR?

Use canonical expr name

Are there any user-facing changes?

No

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Oct 4, 2022
@andygrove andygrove requested a review from alamb October 4, 2022 18:12
@andygrove andygrove changed the title WIP: Fix aggregate type coercion bug Fix aggregate type coercion bug Oct 4, 2022
@andygrove andygrove marked this pull request as ready for review October 4, 2022 21:14
@andygrove
Copy link
Member Author

@alamb Could you take another look at this? I know you are also working on a fix in #3710 so would be good to swap notes

@andygrove
Copy link
Member Author

Closing in favor of #3710

@andygrove andygrove closed this Oct 5, 2022
@andygrove andygrove deleted the fix-aggr-coercion branch January 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate optimizer Optimizer rules

Projects

None yet

2 participants