Add Substring(str [from int] [for int]) support in datafusion-proto
#3902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
approved these changes
Oct 20, 2022
alamb
approved these changes
Oct 20, 2022
| parse_expr(&args[1], registry)?, | ||
| )), | ||
| ScalarFunction::Substr => { | ||
| if args.len() > 2 { |
Contributor
There was a problem hiding this comment.
I recommend adding an assert assert_eq!(args.len(), 3) in this case so that we don't get another silent failure if we add additional argument support to substr
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback, I've added the assert in the new commit :)
Contributor
|
Thanks @r4ntix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3901 and apache/datafusion-ballista#375
Rationale for this change
See #3901
What changes are included in this PR?
substringexpr to supportSubstring(str [from int] [for int])from_proto.rsto supportSubstring(str [from int] [for int])roundtrip_substrtestAre there any user-facing changes?
None