refactor datafusion/scalar_value to use more macro and avoid dup code
#392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2021 13:37
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 74.94% 74.89% -0.05%
==========================================
Files 146 146
Lines 24314 24334 +20
==========================================
+ Hits 18221 18224 +3
- Misses 6093 6110 +17
Continue to review full report at Codecov.
|
jimexist
changed the title
scalar_value to use more macro and avoid dup code
jorgecarleitao
approved these changes
May 23, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
LGTM. Always great to have less code :)
Contributor
|
Looks good. I think there is some more code a bit lower for timestamps that could also use the macro @jimexist |
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
* checkpoint commit * Introduce BaseSessionContext abstract class * Introduce abstract methods for CRUD schema operations * Clean up schema.rs file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
refactor datafusion/scalar value to use more macro and avoid dup code
What changes are included in this PR?
Are there any user-facing changes?