Skip to content

Refactor Expr::Cast to use a struct. #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2022
Merged

Refactor Expr::Cast to use a struct. #3931

merged 4 commits into from
Oct 24, 2022

Conversation

@jackwener
Copy link
Member

@jackwener jackwener commented Oct 23, 2022

Which issue does this PR close?

Part of #2175 and #3807

Rationale for this change

What changes are included in this PR?

Refactor Expr::Cast to use a struct.

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner labels Oct 23, 2022
@jackwener jackwener force-pushed the cast branch 2 times, most recently from 8c8aff0 to b975a8c Compare October 23, 2022 07:25
ygf11
ygf11 reviewed Oct 23, 2022
View reviewed changes
ygf11
ygf11 reviewed Oct 23, 2022
View reviewed changes
ygf11
ygf11 reviewed Oct 23, 2022
View reviewed changes
@jackwener
Copy link
Member Author

jackwener commented Oct 23, 2022

@ygf11 thanks, have resolved

andygrove
andygrove approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jackwener

@andygrove andygrove merged commit b5c23c2 into apache:master Oct 24, 2022
@andygrove andygrove mentioned this pull request Oct 24, 2022
Closed
17 tasks
@jackwener jackwener deleted the cast branch October 24, 2022 13:39
@ursabot
Copy link

ursabot commented Oct 25, 2022

Benchmark runs are scheduled for baseline = e669480 and contender = b5c23c2. b5c23c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygrove andygrove mentioned this pull request Oct 26, 2022
Merged
Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
@jackwener @Dandandan
Refactor Expr::Cast to use a struct. (apache#3931)
22ff7a8 
* Refactor Expr::Cast to use a struct.

* fix

* fix fmt

* fix review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove approved these changes

+1 more reviewer

@ygf11 ygf11 ygf11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackwener @ursabot @andygrove @ygf11