Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Nov 3, 2022

Which issue does this PR close?

Closes #4100

Rationale for this change

New clippy was released that is more strict

I agree with most of its suggested changes so 👍

What changes are included in this PR?

Basically just do what clippy says

Are there any user-facing changes?

No

@alamb alamb mentioned this pull request Nov 3, 2022
@alamb
Copy link
Contributor Author

alamb commented Nov 3, 2022

I think this is non controversial so I plan to merge it in if/when CI tests pass

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates labels Nov 3, 2022
@alamb alamb merged commit fc03001 into apache:master Nov 3, 2022
@alamb alamb deleted the alamb/fix_clippy branch November 3, 2022 20:11
@ursabot
Copy link

ursabot commented Nov 3, 2022

Benchmark runs are scheduled for baseline = c9442ce and contender = fc03001. fc03001 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this pull request Nov 5, 2022
Co-authored-by: Wei-Ting Kuo <waitingkuo0527@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions optimizer Optimizer rules physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clippy failing on master

5 participants