-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix clippy #4190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix clippy #4190
Conversation
|
@alamb @liukun4515 PTAL |
|
failed CI is fix already by #4189 |
|
I wonder if this is clippy failures on a newer rust version (e.g. unstable)? Can you please rebase / merge this branch to master ? The changes look good to me. Thank you @jackwener |
|
Yes, it's clippy failures in nightly version. |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thank you @jackwener
|
Benchmark runs are scheduled for baseline = 4272d96 and contender = 96512ac. 96512ac is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Find in #4185 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?