Skip to content

Conversation

@jackwener
Copy link
Member

Which issue does this PR close?

Find in #4185 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules sql SQL Planner labels Nov 12, 2022
@jackwener
Copy link
Member Author

jackwener commented Nov 12, 2022

@alamb @liukun4515 PTAL

@jackwener
Copy link
Member Author

failed CI is fix already by #4189

@alamb
Copy link
Contributor

alamb commented Nov 12, 2022

I wonder if this is clippy failures on a newer rust version (e.g. unstable)?

Can you please rebase / merge this branch to master ?

The changes look good to me. Thank you @jackwener

@jackwener
Copy link
Member Author

jackwener commented Nov 12, 2022

Yes, it's clippy failures in nightly version.

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Nov 12, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @jackwener

@alamb alamb merged commit 96512ac into apache:master Nov 13, 2022
@ursabot
Copy link

ursabot commented Nov 13, 2022

Benchmark runs are scheduled for baseline = 4272d96 and contender = 96512ac. 96512ac is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jackwener jackwener deleted the clippy branch November 14, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate optimizer Optimizer rules physical-expr Changes to the physical-expr crates sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants