minor: make table resolution an independent function ... #5373
Conversation
waynexia
left a comment
waynexia
left a comment
There was a problem hiding this comment.
Looks good to me. I left a comment about style.
| &self, | ||
| statement: datafusion_sql::parser::Statement, | ||
| ) -> Result<LogicalPlan> { | ||
| statement: &datafusion_sql::parser::Statement, |
There was a problem hiding this comment.
This is not brought in this patch, but it would be better if we could import and use Statement directly
avantgardnerio
left a comment
avantgardnerio
left a comment
There was a problem hiding this comment.
I like the surgical approach to the git diff - it made it very easy to review.
|
Benchmark runs are scheduled for baseline = 05d8a25 and contender = 9fd6efa. 9fd6efa is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
4 participants
Which issue does this PR close?
Closes #.
Rationale for this change
... so people can reuse it from outside.
For some reason, we can't directly use
statement_to_planto generate the logical plan. Upon implementing our own, we found that the codes that resolving tables from statement are very useful. Making the table resolution an independent function enables users to resue more codes from DataFusion.Also there's a small version upgrade of dependency
object_store. All places but one are using version "0.5.4".What changes are included in this PR?
Extract some codes into a function.
Are these changes tested?
yes
Are there any user-facing changes?
no