Skip to content

Conversation

@avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Closes #5418.

Rationale for this change

Described in issue.

What changes are included in this PR?

Update to TableProvider

Are these changes tested?

Yes, existing tests should cover this case.

Are there any user-facing changes?

They will have to update their TableProviders once we do away with the Deprecation and switch for real.

@avantgardnerio avantgardnerio requested review from alamb and andygrove and removed request for alamb February 27, 2023 15:12
@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules labels Feb 27, 2023
@avantgardnerio avantgardnerio merged commit c676d10 into apache:main Feb 27, 2023
@avantgardnerio avantgardnerio deleted the bg_table_provider_fix branch February 27, 2023 17:06
@ursabot
Copy link

ursabot commented Feb 27, 2023

Benchmark runs are scheduled for baseline = 06fecac and contender = c676d10. c676d10 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate optimizer Optimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push down all filters to TableProvider

4 participants