Skip to content

Conversation

@jackwener
Copy link
Member

@jackwener jackwener commented Mar 1, 2023

Which issue does this PR close?

related #5396

Rationale for this change

This test is minimum reproduce case of a bug in tpcds-q58.

"CAST(Int64(100) AS Decimal128(38, 38))"

It will fail in

let col_val = phys_expr.evaluate(&self.input_batch)?;

and throw "ArrowError(ComputeError("Overflow happened on: 100 * 100000000000000000000000000000000000000"))"

What changes are included in this PR?

Add a unit test reproduce a bug.

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Mar 1, 2023
@jackwener
Copy link
Member Author

jackwener commented Mar 1, 2023

I investigate this bug, but I can't fix it. cc @liukun4515 @mingmwang @alamb @jorgecarleitao .

@jackwener jackwener changed the title add a unit test that cover cast problem. add a unit test that cover cast bug. Mar 1, 2023
@alamb
Copy link
Contributor

alamb commented Mar 1, 2023

This is a great reproducer -- thank you @jackwener

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to leave a reference to the ticket this is for 👍

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@jackwener
Copy link
Member Author

It's resolved in arrow-rs apache/arrow-rs#3690

@jackwener jackwener merged commit a4b47d8 into apache:main Mar 2, 2023
@jackwener jackwener deleted the test branch March 2, 2023 03:56
@ursabot
Copy link

ursabot commented Mar 2, 2023

Benchmark runs are scheduled for baseline = 17b2f11 and contender = a4b47d8. a4b47d8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-expr Changes to the physical-expr crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants