Filter push down for Union #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 76.09% 76.10%
=======================================
Files 156 156
Lines 27047 27056 +9
=======================================
+ Hits 20581 20590 +9
Misses 6466 6466
Continue to review full report at Codecov.
|
nevi-me
approved these changes
Jun 14, 2021
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
I'm seeing:
Projection: #COUNT(UInt8(1)) AS total_records, #COUNT(DISTINCT payment_type) AS total_payment_types, #SUM(CAST(trip_distance AS Float64)) AS total_distance
Aggregate: groupBy=[[]], aggr=[[COUNT(UInt8(1)), COUNT(DISTINCT #payment_type), SUM(CAST(#trip_distance AS Float64))]]
Union
Projection: #passenger_count, #trip_distance, #payment_type, #total_amount
TableScan: mongo_nyc projection=Some([3, 4, 9, 16]), filters=[#passenger_count Gt Int64(3), #total_amount Lt Float64(20)]
Projection: #passenger_count, #trip_distance, #payment_type, #total_amount
Filter: #passenger_count Gt Int64(3) And #total_amount Lt Float64(20)
TableScan: csv_nyc projection=Some([3, 4, 9, 16])Thanks @Dandandan
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
H0TB0X420
pushed a commit
to H0TB0X420/datafusion
that referenced
this pull request
Oct 7, 2025
Bumps [syn](https://github.com/dtolnay/syn) from 2.0.41 to 2.0.43. - [Release notes](https://github.com/dtolnay/syn/releases) - [Commits](dtolnay/syn@2.0.41...2.0.43) --- updated-dependencies: - dependency-name: syn dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #557
Rationale for this change
What changes are included in this PR?
Filter is pushed down through union (all), so it can be pushed down further towards other operations like table scans.
Are there any user-facing changes?
FYI @nevi-me