Substrait: Add support for WindowFunction #5653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@waynexia fyi |
nseekhao
force-pushed
the
substrait-window-function
branch
from
3f9d65b to
3a37ebc
Compare
andygrove
reviewed
Mar 21, 2023
| }, | ||
| Some(RexType::WindowFunction(window)) => { | ||
| let fun = match extensions.get(&window.function_reference) { | ||
| Some(function_name) => Ok(find_df_window_func(function_name)), |
Member
There was a problem hiding this comment.
Should we return an error if find_df_window_func returns None here? We unwrap this later on currently, which could fail?
andygrove
approved these changes
Mar 21, 2023
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM. There are a few option unwraps in here (some already existed), and I am not sure if they could cause a panic or not? Perhaps we can follow up with some improved checks for those.
Contributor
Author
|
Makes sense. Should I create an issue for this? |
Member
Yes, that would be great. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes # 5390.
Rationale for this change
Added the ability to producer/consume Substrait plans with WindowFunction
What changes are included in this PR?
LogicalPlan::WindowcaseProjectRel, appendWindowFunctionexpressions before returning the parsedProjectRelProjectRel, add column reference expressions to represent ALL of the fields of the input relation's output. Then appendWindowFunctionexpressions.WindowFunctionWindowFrameUnitsare currently set to eitherRowsorRangedepending on whetherORDER BYis present in theWindowFunction. May need to revisit the cases when frame is explicitly defined.from_substrait_sorts()ORDER BYPARTITION BYWindowFunctionexpressions with column referenceAre these changes tested?
Yes. (cases explained above)
Are there any user-facing changes?
No