Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Mar 30, 2023

Which issue does this PR close?

NA

Rationale for this change

#5780 unfortunately broke the docs build (see https://github.com/apache/arrow-datafusion/actions/runs/4566861530/jobs/8059935571)

I think this is because @sanderson fixed the script to work on mac (it previously was broken) but that sadly broke it on linux.

What changes are included in this PR?

Mess with sed command line

Are these changes tested?

No -- will test 'live'

Are there any user-facing changes?

Not really

@alamb alamb added the development-process Related to development process of DataFusion label Mar 30, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed development-process Related to development process of DataFusion labels Mar 30, 2023
@alamb
Copy link
Contributor Author

alamb commented Mar 30, 2023

I tested this locally on mac and in docker with linux and I think we are good now

@alamb alamb merged commit b779c2f into apache:main Mar 30, 2023
@sanderson
Copy link
Contributor

Oh, shoot! I meant to remove that. Sorry. Thanks for the fix @alamb.

@alamb
Copy link
Contributor Author

alamb commented Mar 30, 2023

Oh, shoot! I meant to remove that. Sorry. Thanks for the fix @alamb.

No worries -- I should have caught it in review 🤦

@alamb alamb deleted the alamb/fix_docs_build branch March 30, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants