minor: Refactor row_hash implementation #5936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafasrepo
commented
Apr 10, 2023
|
|
||
| let row_converter_size_pre = self.row_converter.size(); | ||
| for group_values in &group_by_values { | ||
| let group_rows = self.row_converter.convert_columns(group_values)?; |
Contributor
Author
There was a problem hiding this comment.
This chunk is moved to the function update_group_state
mustafasrepo
commented
Apr 10, 2023
| } | ||
| let batch_indices = batch_indices.finish(); | ||
|
|
||
| let row_values = get_at_indices(&row_aggr_input_values, &batch_indices); |
Contributor
Author
There was a problem hiding this comment.
This chunk is moved to the function update_accumulators
jackwener
changed the title
jackwener
approved these changes
Apr 10, 2023
Member
|
Thanks @mustafasrepo |
korowa
pushed a commit
to korowa/arrow-datafusion
that referenced
this pull request
Apr 13, 2023
* split large chunks to functions * Remove double type annotations --------- Co-authored-by: Mehmet Ozan Kabak <ozankabak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
row_hash.rsfile has large chunks of code inside single function. This makes code hard to read. Also scope of the some variables are larger than necessary, which is limiting.What changes are included in this PR?
This PR refactors
group_aggregate_batch. All code is the same except some sections of the functiongroup_aggregate_batchmovedunder update_group_stateandupdate_accumulators.Also
get_at_indicesfunction now returns Result<> to remove.unwrapinside it.Are these changes tested?
Existing tests should work
Are there any user-facing changes?