fix: return NotImplemented when execute SELECT INTO syntax
#5945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjshen
approved these changes
Apr 10, 2023
Member
|
Please also add a test to justify correct error has been produced. |
Contributor
Author
Thanks for the suggestion! I've added tests for all the syntaxes that select doesn't support. |
korowa
pushed a commit
to korowa/arrow-datafusion
that referenced
this pull request
Apr 13, 2023
…e#5945) * fix: return `NotImplemented` when execute `SELECT INTO` syntax * chore: add tests for select unsupported syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related issue #5943
Rationale for this change
See #5943
What changes are included in this PR?
Temporarily disable
SELECT INTOsupport. But, this does not close #5943 , it does prevent confusion from users.I will spend additional time implementing support for
SELECT INTO.Are these changes tested?
Are there any user-facing changes?