Skip to content

Minor: fix wrong code comment #5979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Minor: fix wrong code comment #5979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions datafusion/core/tests/memory_limit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,10 @@ async fn merge_join() {
.await
}

/// 50 byte memory limit
const MEMORY_FRACTION: f64 = 0.95;

/// runs the specified query against 1000 rows with a 50
/// byte memory limit and no disk manager enabled
/// with default SessionConfig.
/// runs the specified query against 1000 rows with specified
/// memory limit and no disk manager enabled with default SessionConfig.
async fn run_limit_test(
query: &str,
expected_error_contains: Vec<&str>,
Expand Down Expand Up @@ -195,7 +193,6 @@ async fn run_limit_test_with_config(
let rt_config = RuntimeConfig::new()
// do not allow spilling
.with_disk_manager(DiskManagerConfig::Disabled)
// Only allow 50 bytes
.with_memory_limit(memory_limit, MEMORY_FRACTION);

let runtime = RuntimeEnv::new(rt_config).unwrap();
Expand Down