Proper resolution for old name in with_column_renamed #5992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Apr 13, 2023
| // table qualifier optional | ||
| .with_column_renamed("c1", "one")? | ||
| // accepts table qualifier | ||
| .with_column_renamed("aggregate_test_100.c2", "two")? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4428
Rationale for this change
When calling
with_column_renamed("old", "new")in DataFrame API, it should be able to look up"old"column name even if it is not qualified, for ease of use.What changes are included in this PR?
If in plan there is column named
t1.c1(wheret1is the table name andc1is the column name) then allow "c1" for old_name to be able to refer to this column without needing to explicitly state the full qualified nameAlso ensure do an ambiguity check when looking up the old column name
Are these changes tested?
New unit tests added
Are there any user-facing changes?