chore: make JsonOpener and CsvOpener public #6004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
force-pushed
the
chore/json-open-and-csv-opener
branch
from
697a16f to
19e13c2
Compare
alamb
approved these changes
Apr 14, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Seems fine to me -- @WenyXu in order to avoid future regressions, I recommend adding an example of using CsvOpener and JsonOpener into https://github.com/apache/arrow-datafusion/blob/main/datafusion-examples/examples/
Without an example / end user test, it is quite easy for this kind of change to get accidentally broke (for example if we move the structs around). I did something similar with the simplification API when we got broken downstream a few times, and have been quite happy with the result
https://github.com/apache/arrow-datafusion/blob/main/datafusion-examples/examples/expr_api.rs
waynexia
approved these changes
Apr 15, 2023
Member
waynexia
left a comment
waynexia
left a comment
There was a problem hiding this comment.
Looking good 👍 I've checked the examples and they also look good to me.
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
make
JsonOpenerandCsvOpenerpublicWhat changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?